Bug 251057 - AX: Use stronger typing of AccessibilityObject in AXObjectCache, AXIsolatedObject, and AXIsolatedTree
Summary: AX: Use stronger typing of AccessibilityObject in AXObjectCache, AXIsolatedOb...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-23 18:20 PST by Tyler Wilcock
Modified: 2023-01-24 20:08 PST (History)
10 users (show)

See Also:

Attachments
Patch (12.51 KB, patch)
2023-01-23 18:22 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2023-01-23 18:20:31 PST 
We have a bunch of places where we pass an AXCoreObject and immediately ASSERT(is<AccessibilityObject>(object)). We should just use stronger types, which avoids asserts and casting, and possibly helps the compiler perform de-virtualization optimizations.
Comment 1 Radar WebKit Bug Importer 2023-01-23 18:20:44 PST 
<rdar://problem/104582945>
Comment 2 Tyler Wilcock 2023-01-23 18:22:22 PST 
Created attachment 464620 [details]
Patch
Comment 3 EWS 2023-01-24 20:08:55 PST 
Committed 259334@main (d7b129acb04c): <https://commits.webkit.org/259334@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464620 [details].