Bug 251071 - Fix IsoCellSet::remove()'s return value.
Summary: Fix IsoCellSet::remove()'s return value.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-23 23:57 PST by Mark Lam
Modified: 2023-01-24 09:33 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2023-01-23 23:57:56 PST 
In https://bugs.webkit.org/show_bug.cgi?id=250847, Yijia Huang found a bug in Bitmap::concurrentTestAndClear() where it's returning the inverse of its expected result.  Checking for all uses of concurrentTestAndClear(), we find that one result of IsoCellSet::remove() is also similarly incorrect.

This patch fixes these errors, and also adds comments to document the intended return values of some relevant functions, as well as the reasoning behind how some of the return values are computed.
Comment 1 Radar WebKit Bug Importer 2023-01-23 23:58:22 PST 
<rdar://problem/104590361>
Comment 2 Mark Lam 2023-01-24 00:07:18 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9020
Comment 3 EWS 2023-01-24 09:32:55 PST 
Committed 259287@main (3589dd6fe569): <https://commits.webkit.org/259287@main>

Reviewed commits have been landed. Closing PR #9020 and removing active labels.