Bug 251183 - Restrict the set of defaults-overridable flags to better match shipping Safari
Summary: Restrict the set of defaults-overridable flags to better match shipping Safari
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-25 16:06 PST by Brent Fulgham
Modified: 2023-01-26 15:41 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2023-01-25 16:06:52 PST 
The new feature generator logic attempts to persist all `internal` feature flags such that a developer can use a 'WebKitDebug'-prefix for a setting to override it. This is only desired for a small set of feature flags (those that lived in the Source/WTF/Scripts/Preferences/WebPreferencesDebug.yaml file previously).

This patch does the following:

1. Corrects a handful of feature flags that were moved from `internal` to `embedder`, improperly.
2. Adds a new key, `defaultsOverridable` to UnifiedWebPreferences.yaml. Flags that have this key with a `true` value will get additional logic to support 'WebKitDebug'-prefix overrides.
Comment 1 Brent Fulgham 2023-01-25 16:07:06 PST 
<rdar://104657361>
Comment 2 Brent Fulgham 2023-01-25 17:03:06 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9163
Comment 3 EWS 2023-01-26 15:40:58 PST 
Committed 259458@main (0f58ae8a9cfe): <https://commits.webkit.org/259458@main>

Reviewed commits have been landed. Closing PR #9163 and removing active labels.