Bug 251266 - [GTK] Use a weak reference of web view in webkitWebViewGetLoadDecisionForIcon
Summary: [GTK] Use a weak reference of web view in webkitWebViewGetLoadDecisionForIcon
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Garcia Campos
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2023-01-27 06:30 PST by Carlos Garcia Campos
Modified: 2023-01-27 22:43 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2023-01-27 06:30:04 PST 
We don't want to delay the dispose of a web view because an icon load decision is still pending, so let's use a weak reference instead of a strong one. This fixes memory leaks reported by unit tests with 2022 API now that favicons are enabled by default.
Comment 1 Carlos Garcia Campos 2023-01-27 06:39:04 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9228
Comment 2 EWS 2023-01-27 22:43:54 PST 
Committed 259524@main (5757289eb640): <https://commits.webkit.org/259524@main>

Reviewed commits have been landed. Closing PR #9228 and removing active labels.