Bug 251273 - [git-webkit] Support --skip-ews option
Summary: [git-webkit] Support --skip-ews option
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-27 08:25 PST by Jonathan Bedard
Modified: 2023-01-27 10:39 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-01-27 08:25:54 PST 
Given that EWS uses the 'skip-ews' label, git-webkit should support '--skip-ews' along with '--no-ews'. More generally, we should add '--skip' as an inverting prefix to 'NoAction' in webkitcorepy, along with the existing '--no' and '--un', since any '--skip' option in 'NoAction' is almost certainly intended to operate similar to a '--no' prefixed option.
Comment 1 Radar WebKit Bug Importer 2023-01-27 08:27:41 PST 
<rdar://problem/104746176>
Comment 2 Jonathan Bedard 2023-01-27 08:29:19 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9235
Comment 3 EWS 2023-01-27 10:39:03 PST 
Committed 259501@main (770f2f338ad2): <https://commits.webkit.org/259501@main>

Reviewed commits have been landed. Closing PR #9235 and removing active labels.