Bug 251330 - [Wasm-GC] Support arrays of vectors
Summary: [Wasm-GC] Support arrays of vectors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Asumu Takikawa
URL:
Keywords: InRadar
Depends on:
Blocks: 247394
  Show dependency treegraph
 
Reported: 2023-01-28 22:17 PST by Tim Chevalier
Modified: 2024-01-29 09:16 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Chevalier 2023-01-28 22:17:22 PST
https://github.com/WebAssembly/gc/blob/main/proposals/gc/MVP.md implies that arrays of vectors should be supported, e.g. the description of `array.new_canon_data`: "t' is numeric, vector, or packed". That implies that `array.get` and `array.set` should work on arrays of vectors. However, this functionality is currently not implemented in the `JSWebAssemblyArray` class (see the implementations of `get()` and `set()`.) The AIR implementations of `array.new_canon` and `array.get` also use `emitCoerceFromI64` on the input or result value, which crashes with an assertion failure when the source type is `v128`.
Comment 1 Radar WebKit Bug Importer 2023-02-04 22:18:17 PST
<rdar://problem/105050265>
Comment 2 Asumu Takikawa 2024-01-12 13:11:15 PST
Pull request: https://github.com/WebKit/WebKit/pull/22727
Comment 3 EWS 2024-01-29 09:16:28 PST
Committed 273663@main (4750403b1e46): <https://commits.webkit.org/273663@main>

Reviewed commits have been landed. Closing PR #22727 and removing active labels.