Bug 251340 - Save some memory by not putting serialized valueID strings into a hash map
Summary: Save some memory by not putting serialized valueID strings into a hash map
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-29 16:22 PST by Darin Adler
Modified: 2023-01-30 09:18 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2023-01-29 16:22:53 PST 
CSSPrimitiveValue saves strings of serialized values in a map to avoid recomputing them. This is wasteful for the serialized form of CSSValueID, since they are all precomputed at compile time. Putting them in the hash table is a waste of memory.
Comment 1 Radar WebKit Bug Importer 2023-01-29 16:23:32 PST 
<rdar://problem/104803128>
Comment 2 Darin Adler 2023-01-29 22:14:19 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9301
Comment 3 EWS 2023-01-30 09:18:56 PST 
Committed 259562@main (29c1dd855828): <https://commits.webkit.org/259562@main>

Reviewed commits have been landed. Closing PR #9301 and removing active labels.