Bug 251432 - [web-animations] use the keyframe's StyleProperties to determine whether a property is set to "inherit" in a keyframe
Summary: [web-animations] use the keyframe's StyleProperties to determine whether a pr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-31 05:49 PST by Antoine Quint
Modified: 2023-01-31 08:36 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2023-01-31 05:49:12 PST 
Right now we determine whether a property is set to "inherit" in a keyframe by doing a string comparison when the Web Animations API is used to set keyframes. However, the StyleRuleKeyframe created for the keyframe has StyleProperties where the value is parsed, it seems safer to check the CSSValue rather than do a string comparison here.
Comment 1 Antoine Quint 2023-01-31 05:52:11 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9378
Comment 2 EWS 2023-01-31 08:35:14 PST 
Committed 259630@main (9de2e80cf70b): <https://commits.webkit.org/259630@main>

Reviewed commits have been landed. Closing PR #9378 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-01-31 08:36:18 PST 
<rdar://problem/104869270>