Bug 251474 - Refactor JSDOMWrapper.h to not include JSDOMGlobalObject.h
Summary: Refactor JSDOMWrapper.h to not include JSDOMGlobalObject.h
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dan Glastonbury
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-01-31 17:51 PST by Dan Glastonbury
Modified: 2023-01-31 18:00 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Glastonbury 2023-01-31 17:51:00 PST 
Profiling of compilation show that JSDOMGlobalObject.h is the most expensive
header when building WebCore, contributing over 6 minutes across all compilation
units. Moving the implementation of functions from JSDOMWrapper.h to .cpp files
would allow using a forward declaration instead of including an expensive header.
Comment 1 Radar WebKit Bug Importer 2023-01-31 17:51:34 PST 
<rdar://problem/104894173>
Comment 2 Dan Glastonbury 2023-01-31 18:00:19 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9423