Bug 251568 - Add CSSCounterValue, CSSQuadValue, and CSSRectValue, and use CSSValuePair
Summary: Add CSSCounterValue, CSSQuadValue, and CSSRectValue, and use CSSValuePair
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-01 21:56 PST by Darin Adler
Modified: 2023-02-12 20:37 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2023-02-01 21:56:56 PST
In the future we will want to break CSSPrimitiveValue into specific classes for different types. One step in this direction is to do more to hide the underlying objects holding the values, which will likely eventually be held in the CSSValue itself. A good first step is to construct objects directly rather than first constructing a sub-object and passing that to the create function.
Comment 1 Radar WebKit Bug Importer 2023-02-01 21:57:51 PST
<rdar://problem/104946560>
Comment 2 Darin Adler 2023-02-06 06:49:03 PST
Pull request: https://github.com/WebKit/WebKit/pull/9686
Comment 3 EWS 2023-02-12 20:37:39 PST
Committed 260175@main (f5fc580b14bd): <https://commits.webkit.org/260175@main>

Reviewed commits have been landed. Closing PR #9686 and removing active labels.