Bug 251589 - [ews-build.webkit.org] Convert LeaveComment to Twisted asynchronous request
Summary: [ews-build.webkit.org] Convert LeaveComment to Twisted asynchronous request
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-02 08:08 PST by Jonathan Bedard
Modified: 2023-02-02 11:57 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-02-02 08:08:46 PST 
All of our requests should be migrated to Twisted's asynchronous requests so that we don't block the main thread on ews-build.webkit.org
Comment 1 Radar WebKit Bug Importer 2023-02-02 08:09:00 PST 
<rdar://problem/104961332>
Comment 2 Jonathan Bedard 2023-02-02 08:11:33 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9521
Comment 3 EWS 2023-02-02 11:57:38 PST 
Committed 259770@main (26375ba46ade): <https://commits.webkit.org/259770@main>

Reviewed commits have been landed. Closing PR #9521 and removing active labels.