Bug 251619 - JSStringCreateWithCFString can now use CFIndex
Summary: JSStringCreateWithCFString can now use CFIndex
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-02 11:00 PST by Seija K.
Modified: 2023-02-10 12:56 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Seija K. 2023-02-02 11:00:19 PST 
This workaround came about 14 years ago, right when Apple was STILL compiling for PowerPC. Basically, so many devices ran on 32 bits.

A long type can hold onto the required length now, so we no longer need to worry.
Comment 1 Seija K. 2023-02-06 11:26:20 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9542
Comment 2 Radar WebKit Bug Importer 2023-02-09 11:01:24 PST 
<rdar://problem/105230631>
Comment 3 EWS 2023-02-09 13:50:36 PST 
Committed 260083@main (115f2370e6f3): <https://commits.webkit.org/260083@main>

Reviewed commits have been landed. Closing PR #9542 and removing active labels.
Comment 4 Yusuke Suzuki 2023-02-10 12:46:13 PST 
Reverted by https://github.com/WebKit/WebKit/pull/9941
Comment 5 Yusuke Suzuki 2023-02-10 12:46:16 PST 
Re-opening for pull request https://github.com/WebKit/WebKit/pull/9941
Comment 6 EWS 2023-02-10 12:56:17 PST 
Committed 260125@main (27d620c4a193): <https://commits.webkit.org/260125@main>

Reviewed commits have been landed. Closing PR #9941 and removing active labels.