RESOLVED FIXED251628
REGRESSION(256396@main): [STABLE][GStreamer] Accidentally requires GStreamer 1.18.0 
https://bugs.webkit.org/show_bug.cgi?id=251628
Summary REGRESSION(256396@main): [STABLE][GStreamer] Accidentally requires GStreamer ...
Michael Catanzaro
Reported 2023-02-02 13:47:34 PST
WebKitGTK 2.38.4 does not build with GStreamer 1.16. It requires 1.18 due to a missing GST_CHECK_VERSION check. This is an accident: 256396@main adds the check in one place, but not another. ../Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: In function 'void WebCore::fillVideoInfoColorimetryFromColorSpace(GstVideoInfo*, const WebCore::PlatformVideoColorSpace&)': ../Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:860:57: error: 'GST_VIDEO_TRANSFER_BT601' was not declared in this scope GST_VIDEO_INFO_COLORIMETRY(info).transfer = GST_VIDEO_TRANSFER_BT601; ^~~~~~~~~~~~~~~~~~~~~~~~ ../Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:860:57: note: suggested alternative: 'GST_VIDEO_TRANSFER_BT709' GST_VIDEO_INFO_COLORIMETRY(info).transfer = GST_VIDEO_TRANSFER_BT601; ^~~~~~~~~~~~~~~~~~~~~~~~ GST_VIDEO_TRANSFER_BT709
Attachments
Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2023-02-02 15:27:22 PST
This is a stable branch problem. We're missing 256481@main. I'll cherry-pick it.
Adrian Perez
Comment 2 2023-02-03 06:53:51 PST
(In reply to Michael Catanzaro from comment #1) > This is a stable branch problem. We're missing 256481@main. I'll cherry-pick > it. Thanks 🙏️
Note You need to log in before you can comment on or make changes to this bug.