Bug 251628 - REGRESSION(256396@main): [STABLE][GStreamer] Accidentally requires GStreamer 1.18.0
Summary: REGRESSION(256396@main): [STABLE][GStreamer] Accidentally requires GStreamer ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-02 13:47 PST by Michael Catanzaro
Modified: 2023-02-03 06:53 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2023-02-02 13:47:34 PST 
WebKitGTK 2.38.4 does not build with GStreamer 1.16. It requires 1.18 due to a missing GST_CHECK_VERSION check. This is an accident: 256396@main adds the check in one place, but not another.

../Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp: In function 'void WebCore::fillVideoInfoColorimetryFromColorSpace(GstVideoInfo*, const WebCore::PlatformVideoColorSpace&)':
../Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:860:57: error: 'GST_VIDEO_TRANSFER_BT601' was not declared in this scope
             GST_VIDEO_INFO_COLORIMETRY(info).transfer = GST_VIDEO_TRANSFER_BT601;
                                                         ^~~~~~~~~~~~~~~~~~~~~~~~
../Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:860:57: note: suggested alternative: 'GST_VIDEO_TRANSFER_BT709'
             GST_VIDEO_INFO_COLORIMETRY(info).transfer = GST_VIDEO_TRANSFER_BT601;
                                                         ^~~~~~~~~~~~~~~~~~~~~~~~
                                                         GST_VIDEO_TRANSFER_BT709
Comment 1 Michael Catanzaro 2023-02-02 15:27:22 PST 
This is a stable branch problem. We're missing 256481@main. I'll cherry-pick it.
Comment 2 Adrian Perez 2023-02-03 06:53:51 PST 
(In reply to Michael Catanzaro from comment #1)
> This is a stable branch problem. We're missing 256481@main. I'll cherry-pick
> it.

Thanks 🙏️