Bug 251630 - Some data task signposts are not ended properly
Summary: Some data task signposts are not ended properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Nham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-02 14:06 PST by Ben Nham
Modified: 2023-02-03 11:04 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Nham 2023-02-02 14:06:25 PST 
Sometimes, when a data task is cancelled, the didCompleteWithError method is not called. Since that is where we end data task signposts, this can lead to dropped signposts and incorrectly attributed resource loads in perf traces. To fix this, most the end of the signpost to the destructor instead.
Comment 1 Ben Nham 2023-02-02 14:06:39 PST 
<rdar://problem/104976161>
Comment 2 Ben Nham 2023-02-02 14:08:59 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9552
Comment 3 EWS 2023-02-03 11:04:46 PST 
Committed 259826@main (6fb617ebe42b): <https://commits.webkit.org/259826@main>

Reviewed commits have been landed. Closing PR #9552 and removing active labels.