Bug 251637 - Remove getNodesInCommand debug method from Editing commands
Summary: Remove getNodesInCommand debug method from Editing commands
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-02 15:05 PST by Ahmad Saleem
Modified: 2023-02-09 14:33 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-02-02 15:05:04 PST
Hi Team,

While going through Blink's code, I came across this commit doing potential clean-up in HTML Editing code.

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/d773f6263c26f57d4148ff8ba136021f475085d8

I just wanted to raise this bug to check if we have any internal usage of this debug method or not.

Just raising for input and if we can do this clean-up or not.

Thanks!
Comment 1 Ryosuke Niwa 2023-02-02 15:18:26 PST
We could remove it but this function is useful to figure out how many DOM nodes are getting held onto by undo/redo stack.
Comment 2 Ahmad Saleem 2023-02-02 15:38:09 PST
(In reply to Ryosuke Niwa from comment #1)
> We could remove it but this function is useful to figure out how many DOM
> nodes are getting held onto by undo/redo stack.

If it is useless and we don't have alternative, I think we can close this bug but if it is something still worthwhile idea for future because we might have some in pipeline. We can keep this open, what do you suggest?
Comment 3 Ahmad Saleem 2023-02-02 15:38:24 PST
(In reply to Ahmad Saleem from comment #2)
> (In reply to Ryosuke Niwa from comment #1)
> > We could remove it but this function is useful to figure out how many DOM
> > nodes are getting held onto by undo/redo stack.
> 
> If it is useless and we don't have alternative, I think we can close this
> bug but if it is something still worthwhile idea for future because we might
> have some in pipeline. We can keep this open, what do you suggest?

*Useful - I mean.
Comment 4 Brent Fulgham 2023-02-09 14:33:57 PST
Since we use this as a debugging tool, let's close this bug.