RESOLVED WONTFIX251637
Remove getNodesInCommand debug method from Editing commands 
https://bugs.webkit.org/show_bug.cgi?id=251637
Summary Remove getNodesInCommand debug method from Editing commands
Ahmad Saleem
Reported 2023-02-02 15:05:04 PST
Hi Team, While going through Blink's code, I came across this commit doing potential clean-up in HTML Editing code. Blink Commit - https://chromium.googlesource.com/chromium/blink/+/d773f6263c26f57d4148ff8ba136021f475085d8 I just wanted to raise this bug to check if we have any internal usage of this debug method or not. Just raising for input and if we can do this clean-up or not. Thanks!
Attachments
Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2023-02-02 15:18:26 PST
We could remove it but this function is useful to figure out how many DOM nodes are getting held onto by undo/redo stack.
Ahmad Saleem
Comment 2 2023-02-02 15:38:09 PST
(In reply to Ryosuke Niwa from comment #1) > We could remove it but this function is useful to figure out how many DOM > nodes are getting held onto by undo/redo stack. If it is useless and we don't have alternative, I think we can close this bug but if it is something still worthwhile idea for future because we might have some in pipeline. We can keep this open, what do you suggest?
Ahmad Saleem
Comment 3 2023-02-02 15:38:24 PST
(In reply to Ahmad Saleem from comment #2) > (In reply to Ryosuke Niwa from comment #1) > > We could remove it but this function is useful to figure out how many DOM > > nodes are getting held onto by undo/redo stack. > > If it is useless and we don't have alternative, I think we can close this > bug but if it is something still worthwhile idea for future because we might > have some in pipeline. We can keep this open, what do you suggest? *Useful - I mean.
Brent Fulgham
Comment 4 2023-02-09 14:33:57 PST
Since we use this as a debugging tool, let's close this bug.
Note You need to log in before you can comment on or make changes to this bug.