Bug 251663 - Exclude Parser.cpp from being built as part of a unified file.
Summary: Exclude Parser.cpp from being built as part of a unified file.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-02 22:01 PST by Mark Lam
Modified: 2023-02-02 23:26 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2023-02-02 22:01:40 PST 
Parser.cpp is quite large, and under some circumstances, I've seen it cause the compiler to appear to hang when compiling the unified file it got included in.  Excluding it from being in a unified file resolved the hang.  This patch will apply this change.
Comment 1 Radar WebKit Bug Importer 2023-02-02 22:02:29 PST 
<rdar://problem/104992506>
Comment 2 Mark Lam 2023-02-02 22:06:49 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9582
Comment 3 EWS 2023-02-02 23:26:07 PST 
Committed 259803@main (eb73fc333d55): <https://commits.webkit.org/259803@main>

Reviewed commits have been landed. Closing PR #9582 and removing active labels.