WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
251676
RenderLayerScrollableArea::updateResizerStyle should early return if there is no resizer
https://bugs.webkit.org/show_bug.cgi?id=251676
Summary
RenderLayerScrollableArea::updateResizerStyle should early return if there is...
Ahmad Saleem
Reported
2023-02-03 04:03:52 PST
Hi Team, While going through Blink's commit, I came across another early return potential optimization, which I think would be good to add to WebKit. Blink Commit -
https://chromium.googlesource.com/chromium/blink/+/1add5ffe5081cf282014bc4cfe04b8637244c607
WebKit Source -
https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderLayerScrollableArea.cpp#1750
___ It compiles locally with following: if (!m_resizer && !m_layer.canResize()) return; ___ Just wanted to raise this bug for input and if this can also give optimization to WebKit then I can do PR. Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Ahmad Saleem
Comment 1
2023-02-03 04:21:29 PST
Running via EWS to see if there is any regression or test failures -
https://github.com/WebKit/WebKit/pull/9594
On normal local build, I didn't see any glitches etc.
Radar WebKit Bug Importer
Comment 2
2023-02-10 04:04:19 PST
<
rdar://problem/105268291
>
EWS
Comment 3
2023-02-26 14:33:44 PST
Committed
260857@main
(b5f2eee537a0): <
https://commits.webkit.org/260857@main
> Reviewed commits have been landed. Closing PR #9594 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug