Bug 251676 - RenderLayerScrollableArea::updateResizerStyle should early return if there is no resizer
Summary: RenderLayerScrollableArea::updateResizerStyle should early return if there is...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-03 04:03 PST by Ahmad Saleem
Modified: 2023-02-26 14:34 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-02-03 04:03:52 PST 
Hi Team,

While going through Blink's commit, I came across another early return potential optimization, which I think would be good to add to WebKit.

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/1add5ffe5081cf282014bc4cfe04b8637244c607

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderLayerScrollableArea.cpp#1750

___

It compiles locally with following:

if (!m_resizer && !m_layer.canResize())
return;

___

Just wanted to raise this bug for input and if this can also give optimization to WebKit then I can do PR.

Thanks!
Comment 1 Ahmad Saleem 2023-02-03 04:21:29 PST 
Running via EWS to see if there is any regression or test failures - https://github.com/WebKit/WebKit/pull/9594

On normal local build, I didn't see any glitches etc.
Comment 2 Radar WebKit Bug Importer 2023-02-10 04:04:19 PST 
<rdar://problem/105268291>
Comment 3 EWS 2023-02-26 14:33:44 PST 
Committed 260857@main (b5f2eee537a0): <https://commits.webkit.org/260857@main>

Reviewed commits have been landed. Closing PR #9594 and removing active labels.