Bug 251717 - [web-animations] KeyframeEffect::setBlendingKeyframes() should take in an rvalue reference
Summary: [web-animations] KeyframeEffect::setBlendingKeyframes() should take in an rva...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-03 12:37 PST by Antoine Quint
Modified: 2023-02-03 13:42 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2023-02-03 12:37:35 PST 
KeyframeEffect::setBlendingKeyframes() currently takes in an lvalue but its calls WTFMove() on it. That's wrong, it should take in an rvalue.
Comment 1 Antoine Quint 2023-02-03 12:41:20 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9622
Comment 2 EWS 2023-02-03 13:41:58 PST 
Committed 259837@main (78b297d677ce): <https://commits.webkit.org/259837@main>

Reviewed commits have been landed. Closing PR #9622 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-02-03 13:42:29 PST 
<rdar://problem/105019096>