Bug 251769 - Remove unnecessary masking after wasm LLInt comparison instructions.
Summary: Remove unnecessary masking after wasm LLInt comparison instructions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-05 17:41 PST by Mark Lam
Modified: 2023-02-06 01:15 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2023-02-05 17:41:25 PST 
Currently, we always follow a LLInt comparison instructions with an `and with 1` mask.  This is completely unnecessary because the LLInt comparison instructions already always produce a 1 or a 0.  Hence, the `and with 1` mask is effectively a no-op.  This patch removes this unnecessary masking.
Comment 1 Radar WebKit Bug Importer 2023-02-05 17:41:49 PST 
<rdar://problem/105063662>
Comment 2 Mark Lam 2023-02-05 17:48:29 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9666
Comment 3 EWS 2023-02-06 01:15:50 PST 
Committed 259882@main (9354d948240f): <https://commits.webkit.org/259882@main>

Reviewed commits have been landed. Closing PR #9666 and removing active labels.