WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
251809
Devirtualize GraphicsContext::drawConsumingImageBuffer()
https://bugs.webkit.org/show_bug.cgi?id=251809
Summary
Devirtualize GraphicsContext::drawConsumingImageBuffer()
Said Abou-Hallawa
Reported
2023-02-06 11:46:22 PST
GraphicsContext will resolve some of its methods to lower level ones. These higher level methods should not be virtual. These methods are: GraphicsContext::drawImage() GraphicsContext::drawTiledImage() GraphicsContext::drawConsumingImageBuffer() The first two methods will be resolved to GraphicsContext::drawNativeImage() if the Image is a BitmapImage. Or they will be revolved to SVGImage::draw() if it is an SVGImage. SVGImage::draw() will draw a full FrameView. The third method will be resolved to ImageBuffer::drawConsuming() which will draw a NativeImage via GraphicsContext::drawNativeImage().
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-02-06 11:46:49 PST
<
rdar://problem/105092612
>
Said Abou-Hallawa
Comment 2
2023-02-06 11:50:20 PST
Pull request:
https://github.com/WebKit/WebKit/pull/9707
EWS
Comment 3
2023-04-06 18:12:54 PDT
Committed
262695@main
(143e04df42bb): <
https://commits.webkit.org/262695@main
> Reviewed commits have been landed. Closing PR #9707 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug