WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
CLOSED WONTFIX
251883
WTF::ThreadSafeWeakPtrControlBlock::strongDeref() should use constexpr
https://bugs.webkit.org/show_bug.cgi?id=251883
Summary
WTF::ThreadSafeWeakPtrControlBlock::strongDeref() should use constexpr
David Kilzer (:ddkilzer)
Reported
2023-02-07 13:31:23 PST
WTF::ThreadSafeWeakPtrControlBlock::strongDeref() should use constexpr. While working on another patch, I realized that WTF::ThreadSafeWeakPtrControlBlock::strongDeref() could use constexpr instead of a switch statement. The switch statement is kept in Debug builds in case an enum value is added to DestructionThread.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-02-07 13:35:27 PST
<
rdar://problem/105143972
>
David Kilzer (:ddkilzer)
Comment 2
2023-02-07 13:37:28 PST
Pull request:
https://github.com/WebKit/WebKit/pull/9779
David Kilzer (:ddkilzer)
Comment 3
2023-02-08 08:18:49 PST
Alex notes that the switch statement is already optimized out, so the constexpr isn't needed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug