Bug 251912 - [GLIB] Disable hinting for testing
Summary: [GLIB] Disable hinting for testing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-08 02:29 PST by Vitaly Dyackhov
Modified: 2023-02-17 06:17 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Dyackhov 2023-02-08 02:29:13 PST 
Currently, when rendering text on the GTK platform, font system options such as antialiasing and hinting are taken into account. While this is generally good, it would be great to have a deterministic testing environment.
Comment 1 Vitaly Dyackhov 2023-02-08 02:45:48 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9805
Comment 2 Vitaly Dyackhov 2023-02-15 04:25:01 PST 
There are some tests that differ between GTK and WPE because GTK WebKitTestRunner disables font hinting. It does it by using `GtkSettingsManager` mechanism which doesn't exist on WPE. It would be great to have a way to disable hinting that works on both platforms. It will let us then use the same baselines for such tests.
Comment 3 Carlos Garcia Campos 2023-02-15 04:36:21 PST 
Or enable hinting for WPE for testing.
Comment 4 Vitaly Dyackhov 2023-02-15 04:41:46 PST 
Hinting is enabled on WPE by default. And currently, there is no API to change it. If understand it correctly, enabling hinting can lead to flaky or even failing tests.
Comment 5 Carlos Garcia Campos 2023-02-15 05:47:41 PST 
Ok, that makes sense, then.
Comment 6 EWS 2023-02-17 06:17:03 PST 
Committed 260443@main (34e13090c605): <https://commits.webkit.org/260443@main>

Reviewed commits have been landed. Closing PR #9805 and removing active labels.