RESOLVED FIXED251914
BuilderConverter::convertLineHeight() should not return an std::optional<Length> 
https://bugs.webkit.org/show_bug.cgi?id=251914
Summary BuilderConverter::convertLineHeight() should not return an std::optional<Length>
Antoine Quint
Reported 2023-02-08 04:58:39 PST
There is this comment at the end of BuilderConverter::convertLineHeight(): // FIXME: The parser should only emit the above types, so this should never be reached. We should change the // type of this function to return just a Length (and not an Optional). return std::nullopt; Let's fix this!
Attachments
Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2023-02-08 05:01:10 PST
Pull request: https://github.com/WebKit/WebKit/pull/9809
EWS
Comment 2 2023-02-08 12:30:04 PST
Committed 260027@main (c436cfbb0eb0): <https://commits.webkit.org/260027@main> Reviewed commits have been landed. Closing PR #9809 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-02-08 12:31:20 PST
<rdar://problem/105187506>
Note You need to log in before you can comment on or make changes to this bug.