Bug 251918 - Minor cleanup in PageSerializer::serializeFrame
Summary: Minor cleanup in PageSerializer::serializeFrame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-08 08:09 PST by Ahmad Saleem
Modified: 2023-02-09 00:00 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-02-08 08:09:06 PST 
Hi Team,

While going through Blink's commit, I came across another potential merge:

Blink Commit - https://chromium.googlesource.com/chromium/blink/+/740273d8a82eb6fb83447173cf3a5f682b498bbb

WebKit Source - https://searchfox.org/wubkat/source/Source/WebCore/page/PageSerializer.cpp#193

____

Vector<Node*> serializedNodes;
SerializerMarkupAccumulator accumulator(*this, *document, &serializedNodes);

and

for (auto& node : serializedNodes) {

____

It compiles and work in local testing.

Appreciate if someone can confirm, it is right approach, so I can do PR.

Thanks!
Comment 1 Ryosuke Niwa 2023-02-08 09:49:09 PST 
We could merge that although there doesn't seem to be much upside to it either.
Comment 2 Ahmad Saleem 2023-02-08 09:49:52 PST 
(In reply to Ryosuke Niwa from comment #1)
> We could merge that although there doesn't seem to be much upside to it
> either.

removing unused string only I can think of. :-)
Comment 3 EWS 2023-02-08 23:59:29 PST 
Committed 260051@main (d8939a222b9d): <https://commits.webkit.org/260051@main>

Reviewed commits have been landed. Closing PR #9821 and removing active labels.
Comment 4 Radar WebKit Bug Importer 2023-02-09 00:00:18 PST 
<rdar://problem/105210497>