WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
251919
Page Serializer: Specify encoding for serialized CSS files
https://bugs.webkit.org/show_bug.cgi?id=251919
Summary
Page Serializer: Specify encoding for serialized CSS files
Ahmad Saleem
Reported
2023-02-08 08:20:05 PST
Hi Team, Wile going through Blink's commit, I came across another potential one but I am not sure, whether it will have an impact since we don't have MHTML but we seems have to have FIXME: Blink Commit -
https://chromium.googlesource.com/chromium/src.git/+/f7030ffe17ea03cf8a2e9189d7d764dfd07da26a
WebKit Source FIXME -
https://searchfox.org/wubkat/source/Source/WebCore/page/PageSerializer.cpp#267
We don't have appendLiteral, so following needs to be added after Line 242: cssText.append("@charset \""); cssText.append(styleSheet->contents().charset().convertToASCIILowercase()); cssText.append("\";\n\n"); ___ Don't know equivalent of lower() from blink commit but I think it would be 'convertToASCIILowercase()'. Just wanted to raise a get input whether to merge it or get rid of "FIXME". Don't have testcase as well. :-( Thanks!
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2023-02-15 08:21:17 PST
<
rdar://problem/105497144
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug