Bug 251919 - Page Serializer: Specify encoding for serialized CSS files
Summary: Page Serializer: Specify encoding for serialized CSS files
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-08 08:20 PST by Ahmad Saleem
Modified: 2023-02-15 08:21 PST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2023-02-08 08:20:05 PST
Hi Team,

Wile going through Blink's commit, I came across another potential one but I am not sure, whether it will have an impact since we don't have MHTML but we seems have to have FIXME:

Blink Commit - https://chromium.googlesource.com/chromium/src.git/+/f7030ffe17ea03cf8a2e9189d7d764dfd07da26a

WebKit Source FIXME - https://searchfox.org/wubkat/source/Source/WebCore/page/PageSerializer.cpp#267

We don't have appendLiteral, so following needs to be added after Line 242:

cssText.append("@charset \"");
cssText.append(styleSheet->contents().charset().convertToASCIILowercase());
cssText.append("\";\n\n");

___

Don't know equivalent of lower() from blink commit but I think it would be 'convertToASCIILowercase()'.

Just wanted to raise a get input whether to merge it or get rid of "FIXME". Don't have testcase as well. :-(

Thanks!
Comment 1 Radar WebKit Bug Importer 2023-02-15 08:21:17 PST
<rdar://problem/105497144>