Bug 251960 - [git-webkit] Consider redaction of all issues in PR
Summary: [git-webkit] Consider redaction of all issues in PR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-08 16:29 PST by Jonathan Bedard
Modified: 2023-02-14 13:23 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-02-08 16:29:30 PST 
Right now, git-webkit only considers the first PR in the HEAD commit when determining if a PR should be redacted. git-webkit should inspect every issue in every commit on the PR branch and consider the whole PR redacted if a single one of these issues requires redaction.
Comment 1 Radar WebKit Bug Importer 2023-02-08 16:30:04 PST 
<rdar://problem/105197556>
Comment 2 Jonathan Bedard 2023-02-08 16:32:55 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9843
Comment 3 EWS 2023-02-10 10:46:58 PST 
Committed 260117@main (d1b770d8e28b): <https://commits.webkit.org/260117@main>

Reviewed commits have been landed. Closing PR #9843 and removing active labels.
Comment 4 EWS 2023-02-14 13:23:33 PST 
Committed 259548.164@safari-7615-branch (3cc30ef58a32): <https://commits.webkit.org/259548.164@safari-7615-branch>

Reviewed commits have been landed. Closing PR #389 and removing active labels.