RESOLVED FIXED252013
REGRESSION(260052@main): builtins-generator-tests are failing 
https://bugs.webkit.org/show_bug.cgi?id=252013
Summary REGRESSION(260052@main): builtins-generator-tests are failing
Diego Pino
Reported 2023-02-09 14:05:37 PST
builtins-generator-tests are failing after 260052@main. ``` $ python3 Tools/Scripts/run-builtins-generator-tests PASS: JavaScriptCore-Builtin.prototype-Separate.js-result PASS: JavaScriptCore-InternalClashingNames-Combined.js-error PASS: JavaScriptCore-InternalClashingNames-Combined.js-result PASS: JavaScriptCore-BuiltinConstructor-Separate.js-result PASS: WebCore-DuplicateFlagAnnotation-Separate.js-error PASS: WebCore-GuardedInternalBuiltin-Separate.js-result PASS: WebCore-AnotherGuardedInternalBuiltin-Separate.js-result PASS: WebCore-UnguardedBuiltin-Separate.js-result PASS: JavaScriptCore-BuiltinConstructor-Combined.js-result PASS: JavaScriptCore-Builtin.Promise-Separate.js-result PASS: WebCore-xmlCasingTest-Separate.js-result PASS: WebCore-ArbitraryConditionalGuard-Separate.js-result PASS: JavaScriptCore-Builtin.prototype-Combined.js-result PASS: WebCore-DuplicateKeyValueAnnotation-Separate.js-error PASS: WebCore-GuardedBuiltin-Separate.js-result PASS: JavaScriptCore-Builtin.Promise-Combined.js-result FAIL: WebCoreJSBuiltins.h-result --- JavaScriptCore/Scripts/tests/builtins/expected/WebCoreJSBuiltins.h-result 2023-02-09 14:04:00.032523651 -0800 +++ /tmp/tmp24u7kqm8builtin-generator-tests/WebCoreJSBuiltins.h-result 2023-02-09 14:04:08.572550434 -0800 @@ -266,8 +266,8 @@ #include "WebCoreJSClientData.h" #include <JavaScriptCore/HeapInlines.h> #include <JavaScriptCore/JSCJSValueInlines.h> +#include <JavaScriptCore/JSObjectInlines.h> #include <JavaScriptCore/SlotVisitorInlines.h> -#include <JavaScriptCore/StructureInlines.h> namespace WebCore { Some tests FAIL! (To update the reference files, execute "run-builtins-generator-tests --reset-results") ``` The test needs to update its expected results.
Attachments
Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2023-02-09 14:09:55 PST
Pull request: https://github.com/webkit/webkit/pull/9890
EWS
Comment 2 2023-02-09 18:02:25 PST
Committed 260097@main (d65f42e0696b): <https://commits.webkit.org/260097@main> Reviewed commits have been landed. Closing PR #9890 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-02-09 18:03:18 PST
<rdar://problem/105248958>
Note You need to log in before you can comment on or make changes to this bug.