Bug 252051 - [web-animations] mark AnimationEffect subclasses as final
Summary: [web-animations] mark AnimationEffect subclasses as final
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-10 05:20 PST by Antoine Quint
Modified: 2023-02-10 09:43 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2023-02-10 05:20:18 PST 
AnimationEffect has two subclasses: CustomEffect and KeyframeEffect. None of those have subclasses of their own, so they should both be marked final.
Comment 1 Antoine Quint 2023-02-10 05:23:06 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9922
Comment 2 EWS 2023-02-10 09:42:44 PST 
Committed 260112@main (b84c65e04ccc): <https://commits.webkit.org/260112@main>

Reviewed commits have been landed. Closing PR #9922 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-02-10 09:43:20 PST 
<rdar://problem/105281385>