Bug 252057 - [GLIB] Unify code for accessing default `cairo_font_options`
Summary: [GLIB] Unify code for accessing default `cairo_font_options`
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-10 08:17 PST by Vitaly Dyackhov
Modified: 2023-02-15 01:02 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Dyackhov 2023-02-10 08:17:53 PST 
Currently, there are two different implementations of `getDefaultCairoFontOptions()` on WPE and GTK. WPE version simply returns a static value created by `cairo_font_options_create()`, whereas GTK one is creating a singleton class that stores and updates an instance variable to keep it in sync with `GtkSettings`.
Comment 1 Vitaly Dyackhov 2023-02-10 08:24:43 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9929
Comment 2 EWS 2023-02-15 01:02:23 PST 
Committed 260301@main (9ccc5caacd23): <https://commits.webkit.org/260301@main>

Reviewed commits have been landed. Closing PR #9929 and removing active labels.