Bug 252064 - Fix mistakes in WebKitTargetConditionals.xcconfig
Summary: Fix mistakes in WebKitTargetConditionals.xcconfig
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks: 252066 252970 269799
  Show dependency tree / graph
 
Reported: 2023-02-10 10:42 PST by David Kilzer (:ddkilzer)
Modified: 2024-02-20 10:54 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2023-02-10 10:42:00 PST 
Fix mistakes in WebKitTargetConditionals.xcconfig.

The following macros are defined incorrectly (they result in circular definitions):

```
WK_IOS_17 = $(WK_IOS_17_$(WK_IOS_BEFORE_17));
WK_IOS_17_ = $(WK_IOS_17);  // BUG: Circular definition.
[...]
WK_TVOS_16 = $(WK_TVOS_16_$(WK_TVOS_BEFORE_16));
WK_TVOS_16_ = $(WK_TVOS_16);  // BUG: Circular definition.
[...]
WK_TVOS_17 = $(WK_TVOS_17_$(WK_TVOS_BEFORE_17));
WK_TVOS_17_ = $(WK_TVOS_17);  // BUG: Circular definition.
```

The net effect of this error was that Bug 245692 had no effect on iOS builds because `WK_IOS_17` would never be defined as `_IOS_SINCE_17`:

    Enable libc++ assertions
    https://bugs.webkit.org/show_bug.cgi?id=245692
    rdar://100416021
    https://commits.webkit.org/259122@main
Comment 1 Radar WebKit Bug Importer 2023-02-10 10:42:28 PST 
<rdar://problem/105284669>
Comment 2 David Kilzer (:ddkilzer) 2023-02-10 10:52:47 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9936
Comment 3 EWS 2023-02-10 16:16:11 PST 
Committed 260134@main (adf544afeb9f): <https://commits.webkit.org/260134@main>

Reviewed commits have been landed. Closing PR #9936 and removing active labels.