Bug 252076 - Remove unused multi-version iOS variables from WebKitTargetConditionals.xcconfig
Summary: Remove unused multi-version iOS variables from WebKitTargetConditionals.xcconfig
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks: 269799
  Show dependency treegraph
 
Reported: 2023-02-10 14:11 PST by David Kilzer (:ddkilzer)
Modified: 2024-02-20 10:54 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2023-02-10 14:11:51 PST
Remove unused multi-version iOS variables from WebKitTargetConditionals.xcconfig.

They aren't used anywhere inside WebKit, and they haven't been kept up-to-date after `WK_IOS_17` was added, so they likely aren't used any longer.

Referring to these Xcode variables in Configurations/WebKitTargetConditionals.xcconfig:

'''
WK_IOS_13_14 = $(WK_IOS_13_14_$(WK_IOS_BEFORE_13));
WK_IOS_13_14_ = $(WK_IOS_14);
WK_IOS_13_14_YES = _IOS_BEFORE_13;

WK_IOS_13_15 = $(WK_IOS_13_15_$(WK_IOS_BEFORE_13));
WK_IOS_13_15_ = $(WK_IOS_15);
WK_IOS_13_15_YES = _IOS_BEFORE_13;

WK_IOS_13_16 = $(WK_IOS_13_16_$(WK_IOS_BEFORE_13));
WK_IOS_13_16_ = $(WK_IOS_16);
WK_IOS_13_16_YES = _IOS_BEFORE_13;

[...]

WK_IOS_14_15 = $(WK_IOS_14_15_$(WK_IOS_BEFORE_14));
WK_IOS_14_15_ = $(WK_IOS_15);
WK_IOS_14_15_YES = _IOS_BEFORE_14;

WK_IOS_14_16 = $(WK_IOS_14_16_$(WK_IOS_BEFORE_14));
WK_IOS_14_16_ = $(WK_IOS_16);
WK_IOS_14_16_YES = _IOS_BEFORE_14;

[...]

WK_IOS_15_16 = $(WK_IOS_15_16_$(WK_IOS_BEFORE_15));
WK_IOS_15_16_ = $(WK_IOS_16);
WK_IOS_15_16_YES = _IOS_BEFORE_15;

[...]

WK_IOS_16_17 = $(WK_IOS_16_17_$(WK_IOS_BEFORE_16));
WK_IOS_16_17_ = $(WK_IOS_17);
WK_IOS_16_17_YES = _IOS_BEFORE_16;
'''
Comment 1 Radar WebKit Bug Importer 2023-02-10 14:12:12 PST
<rdar://problem/105295734>
Comment 2 David Kilzer (:ddkilzer) 2023-02-10 14:14:35 PST
BTW, the existence of these variables may have lead to this apparent copy-paste mistake:

    Fix mistakes in WebKitTargetConditionals.xcconfig
    https://bugs.webkit.org/show_bug.cgi?id=252064
Comment 3 David Kilzer (:ddkilzer) 2023-02-10 14:16:37 PST
Pull request: https://github.com/WebKit/WebKit/pull/9947
Comment 4 EWS 2023-02-18 09:57:45 PST
Committed 260514@main (093c15d17e01): <https://commits.webkit.org/260514@main>

Reviewed commits have been landed. Closing PR #9947 and removing active labels.