Bug 252129 - Make CachedSubimage part of PDFDocumentImage
Summary: Make CachedSubimage part of PDFDocumentImage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Images (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
: 252194 (view as bug list)
Depends on:
Blocks: 245858
  Show dependency tree / graph
 
Reported: 2023-02-11 23:24 PST by Said Abou-Hallawa
Modified: 2023-02-13 17:56 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2023-02-11 23:24:49 PST 
Making it part of the Image was wrong. For now it makes sense only to be part of PDFDocumentImage. It can't be part BitmapImage since BitmapImage can display multiple NativeImages. So in future patches, it will be made also part of the NativeImage.
Comment 1 Radar WebKit Bug Importer 2023-02-11 23:25:08 PST 
<rdar://problem/105351788>
Comment 2 Said Abou-Hallawa 2023-02-11 23:32:02 PST 
Pull request: https://github.com/WebKit/WebKit/pull/9994
Comment 3 Said Abou-Hallawa 2023-02-13 14:56:44 PST 
*** Bug 252194 has been marked as a duplicate of this bug. ***
Comment 4 EWS 2023-02-13 17:56:07 PST 
Committed 260236@main (6f7d211e4d86): <https://commits.webkit.org/260236@main>

Reviewed commits have been landed. Closing PR #9994 and removing active labels.