Bug 252142 - reduce custom property storage for sites with large numbers of custom properties on the root
Summary: reduce custom property storage for sites with large numbers of custom propert...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-12 19:35 PST by Cameron McCormack (:heycam)
Modified: 2023-02-15 10:43 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2023-02-12 19:35:42 PST 
Some sites have a large number of custom properties set on the root element, inheriting into the entire document.  When different custom properties or values are set on descendant elements, we clone all of the inherited properties.  We can adjust the way we store and inherit custom properties to handle this pattern with less memory use.
Comment 1 Radar WebKit Bug Importer 2023-02-12 19:36:00 PST 
<rdar://problem/105372920>
Comment 2 Cameron McCormack (:heycam) 2023-02-12 19:52:35 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10007
Comment 3 EWS 2023-02-15 10:43:02 PST 
Committed 260319@main (147e3eca970c): <https://commits.webkit.org/260319@main>

Reviewed commits have been landed. Closing PR #10007 and removing active labels.