Bug 252143 - Fix TestWebKitAPI build when including WKFeature.h
Summary: Fix TestWebKitAPI build when including WKFeature.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-12 20:06 PST by David Kilzer (:ddkilzer)
Modified: 2023-02-12 21:15 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2023-02-12 20:06:46 PST
Fix TestWebKitAPI build when including WKFeature.h.

Seen in these EWS builds:
  <https://ews-build.webkit.org/#/builders/43/builds/40334>
  <https://ews-build.webkit.org/#/builders/85/builds/7733>

```
In file included from /Volumes/Data/worker/macOS-BigSur-Release-Build-EWS/build/Tools/TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:26:
In file included from /Volumes/Data/worker/macOS-BigSur-Release-Build-EWS/build/Tools/TestWebKitAPI/config.h:69:
In file included from /Volumes/Data/worker/macOS-BigSur-Release-Build-EWS/build/WebKitBuild/Release/WebKit.framework/PrivateHeaders/WebKit2_C.h:40:
/Volumes/Data/worker/macOS-BigSur-Release-Build-EWS/build/WebKitBuild/Release/WebKit.framework/PrivateHeaders/WKFeature.h:34:38: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
WK_EXPORT WKTypeID WKFeatureGetTypeID();
                                     ^
                                      void
1 error generated.
```
Comment 1 Radar WebKit Bug Importer 2023-02-12 20:07:06 PST
<rdar://problem/105373344>
Comment 2 David Kilzer (:ddkilzer) 2023-02-12 20:11:08 PST
Pull request: https://github.com/WebKit/WebKit/pull/10008
Comment 3 EWS 2023-02-12 21:15:27 PST
Committed 260176@main (be80c071ab73): <https://commits.webkit.org/260176@main>

Reviewed commits have been landed. Closing PR #10008 and removing active labels.