Bug 252176 - [css-nesting] Save memory when we only need old-school StyleRule (=non nested)
Summary: [css-nesting] Save memory when we only need old-school StyleRule (=non nested)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-13 09:28 PST by Matthieu Dubet
Modified: 2023-02-14 15:21 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Dubet 2023-02-13 09:28:52 PST 
Support for CSS Nesting adds 2 members to the StyleRule class (the resolved selector list, and the list of children rules).

This creates a regression in Membuster benchmark (~2Mb). 

We should have a "happy path" where we don't pay the memory cost of the nesting feature when we don't need it.
Comment 1 Radar WebKit Bug Importer 2023-02-13 09:29:10 PST 
<rdar://problem/105399781>
Comment 2 Matthieu Dubet 2023-02-13 10:04:24 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10044
Comment 3 EWS 2023-02-14 15:21:13 PST 
Committed 260281@main (9db1de406e2b): <https://commits.webkit.org/260281@main>

Reviewed commits have been landed. Closing PR #10044 and removing active labels.