Bug 252177 - [git] Respect _ in hooks
Summary: [git] Respect _ in hooks
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-13 10:20 PST by Jonathan Bedard
Modified: 2023-02-13 16:06 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2023-02-13 10:20:48 PST 
When git invokes a hook, it passes the path to the git command used to invoke this hook via the environment varialbe '_'. We should respect this environment variable in our hooks.
Comment 1 Radar WebKit Bug Importer 2023-02-13 10:21:36 PST 
<rdar://problem/105402860>
Comment 2 Jonathan Bedard 2023-02-13 11:25:56 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10048
Comment 3 Jonathan Bedard 2023-02-13 16:06:40 PST 
This is a very bad idea, as it turns out, `_` will be `git-webkit` if `git-webkit` invokes `git`.