RESOLVED FIXED252213
[WGSL] Fix line number reporting in errors 
https://bugs.webkit.org/show_bug.cgi?id=252213
Summary [WGSL] Fix line number reporting in errors
Dan Glastonbury
Reported 2023-02-13 16:40:13 PST
Text editors use one-based line numbering, not zero. When setting source code to be tokenized, set the current position to offset of 0 on line 1. This allows a position with m_line set to 0 to represent and empty or invalid position.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2023-02-13 16:40:59 PST
<rdar://problem/105423092>
Dan Glastonbury
Comment 2 2023-02-13 16:42:32 PST
Pull request: https://github.com/WebKit/WebKit/pull/10064
EWS
Comment 3 2023-02-13 18:12:38 PST
Committed 260237@main (5152a874639a): <https://commits.webkit.org/260237@main> Reviewed commits have been landed. Closing PR #10064 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.