Bug 252224 - [WGSL] Handle lexing of line and block comments
Summary: [WGSL] Handle lexing of line and block comments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Dan Glastonbury
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-13 20:00 PST by Dan Glastonbury
Modified: 2023-02-14 14:56 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Glastonbury 2023-02-13 20:00:38 PST 
WGSL supports single-line comments prefixed with // and block-comments delimited
by /* and */. Block comments can be nested so, unlike in C & C++, /* /* */ */ is
valid.
Comment 1 Radar WebKit Bug Importer 2023-02-13 20:01:05 PST 
<rdar://problem/105430947>
Comment 2 Dan Glastonbury 2023-02-13 20:09:13 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10070
Comment 3 EWS 2023-02-14 14:56:13 PST 
Committed 260277@main (4c345f6c8991): <https://commits.webkit.org/260277@main>

Reviewed commits have been landed. Closing PR #10070 and removing active labels.