Bug 252236 - [WPE] Build broken with external holepunch enabled
Summary: [WPE] Build broken with external holepunch enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Miguel Gomez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-14 01:53 PST by Miguel Gomez
Modified: 2023-02-14 03:57 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2023-02-14 01:53:44 PST 
There are 2 build errors:
- MediaPlayerPrivate::setSize(), which is overridden by MediaPlayerPrivateHolePunch::setSize() was renamed to MediaPlayerPrivate::setPresentationSize(), so the one in MediaPlayerPrivateHolePunch must be renamed too.

- The String class constructor that receives a char* is now private, so we need to use a different way to create the mime type Strings.
Comment 1 Miguel Gomez 2023-02-14 02:16:33 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10082
Comment 2 EWS 2023-02-14 03:57:17 PST 
Committed 260251@main (38f8a723a95d): <https://commits.webkit.org/260251@main>

Reviewed commits have been landed. Closing PR #10082 and removing active labels.