RESOLVED FIXED252258
REGRESSION(258448@main): Build failure with ruby 2.5 
https://bugs.webkit.org/show_bug.cgi?id=252258
Summary REGRESSION(258448@main): Build failure with ruby 2.5
Mike Gorse
Reported 2023-02-14 11:19:34 PST
I am getting a build failure building webkitgtk 2.39.7 on SLE-15-SP4 (equivalent to openSUSE leap 15.4): /home/abuild/rpmbuild/BUILD/webkitgtk-2.39.7/Source/WebCore/Scripts/GenerateSettings.rb:47: syntax error, unexpected ')' ...tingsFiles] = ARGV.slice!(0...) I presume the (0...) is a ruby 3 idiom. Cmake checks for ruby 1.9 or newer.
Attachments
Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2023-02-14 11:49:40 PST
Looks like this broke in 258448@main "Generate web preferences using feature status taxonomy" Even though it might be time to bump our minimum required ruby version to something higher than 1.9, our dependencies policy would limit us to 2.7 (default ruby in Ubuntu 20.04) anyway, so let's find a different way to write this code.
Elliott Williams
Comment 2 2023-02-14 11:53:01 PST
Ack, thanks for finding the regression. Would you prefer I rewrite and test this with Ruby 1.9, or can I go ahead and raise the minimum required version (and still rewrite it for 2.x compatibility)? Being able to rely on 2.7 would be great.
Michael Catanzaro
Comment 3 2023-02-14 12:31:43 PST
So technically you're allowed to use 2.7 if you really want to... but it'd be kinder to Mike if we limit ourselves to max 2.5. (Um, and kinder to me too, since I also have to build with 2.5. :)
Elliott Williams
Comment 4 2023-02-14 13:59:52 PST
Pull request: https://github.com/WebKit/WebKit/pull/10107
EWS
Comment 5 2023-02-14 16:40:40 PST
Committed 260286@main (c831480bdef2): <https://commits.webkit.org/260286@main> Reviewed commits have been landed. Closing PR #10107 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.