Bug 252265 - Build failure with python 3.6
Summary: Build failure with python 3.6
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-02-14 13:54 PST by Mike Gorse
Modified: 2023-02-16 00:59 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Gorse 2023-02-14 13:54:41 PST 
For subprocess.popen, text is a synonym for universal_newlines, added in python 3.7.
Comment 1 Michael Catanzaro 2023-02-14 14:49:29 PST 
Are you planning to submit a patch for this?
Comment 2 Michael Catanzaro 2023-02-14 14:50:21 PST 
I assume so, because you didn't mention where the problem was. :D
Comment 3 Mike Gorse 2023-02-14 17:16:41 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10114
Comment 4 EWS 2023-02-16 00:59:50 PST 
Committed 260357@main (cccd00688012): <https://commits.webkit.org/260357@main>

Reviewed commits have been landed. Closing PR #10114 and removing active labels.