Bug 252278 - [WGSL] Use a SortedArrayMap to match keywords and reserved words
Summary: [WGSL] Use a SortedArrayMap to match keywords and reserved words
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dan Glastonbury
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-14 17:50 PST by Dan Glastonbury
Modified: 2023-02-15 17:40 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dan Glastonbury 2023-02-14 17:50:36 PST 
In lieu of a tool to generate a trie for detecting keywords and reserved words,
replace the long sequence of if/return with a SortedArrayMap of keyword to
TokenType.
Comment 1 Radar WebKit Bug Importer 2023-02-14 17:51:13 PST 
<rdar://problem/105476092>
Comment 2 Dan Glastonbury 2023-02-14 20:56:33 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10121
Comment 3 EWS 2023-02-15 17:40:05 PST 
Committed 260336@main (9ee0c4ea8853): <https://commits.webkit.org/260336@main>

Reviewed commits have been landed. Closing PR #10121 and removing active labels.