RESOLVED FIXED252282
[IFC][Partial layout] Do not rely on the number of lines in InlineFormattingState when computing the current line index. 
https://bugs.webkit.org/show_bug.cgi?id=252282
Summary [IFC][Partial layout] Do not rely on the number of lines in InlineFormattingS...
alan
Reported 2023-02-14 19:31:15 PST
ssia
Attachments
Patch (7.77 KB, patch)
2023-02-14 19:32 PST, alan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2023-02-14 19:32:44 PST
Created attachment 464994 [details] Patch
Antti Koivisto
Comment 2 2023-02-15 07:13:32 PST
Comment on attachment 464994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=464994&action=review > COMMIT_MESSAGE:1 > +[IFC][Partial layout] Using the number of cached lines in InlineFormattingState as a hint for the current line index does not work well with partial layout Not sure I understand the title.
alan
Comment 3 2023-02-15 07:39:09 PST
InlineFormattingState only contains the line generated at the current layout. With partial layout, this number may be very different from how many lines we actually have altogether.
EWS
Comment 4 2023-02-16 09:03:29 PST
Committed 260372@main (2e812cbdaf7d): <https://commits.webkit.org/260372@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 464994 [details].
Radar WebKit Bug Importer
Comment 5 2023-02-16 09:04:19 PST
<rdar://problem/105550749>
alan
Comment 6 2023-02-16 09:37:11 PST
oops, I forgot to change the title in the commit message :(
Note You need to log in before you can comment on or make changes to this bug.