Bug 252282 - [IFC][Partial layout] Do not rely on the number of lines in InlineFormattingState when computing the current line index.
Summary: [IFC][Partial layout] Do not rely on the number of lines in InlineFormattingS...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-14 19:31 PST by zalan
Modified: 2023-02-16 09:37 PST (History)
5 users (show)

See Also:

Attachments
Patch (7.77 KB, patch)
2023-02-14 19:32 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-02-14 19:31:15 PST 
ssia
Comment 1 zalan 2023-02-14 19:32:44 PST 
Created attachment 464994 [details]
Patch
Comment 2 Antti Koivisto 2023-02-15 07:13:32 PST 
Comment on attachment 464994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=464994&action=review

> COMMIT_MESSAGE:1
> +[IFC][Partial layout] Using the number of cached lines in InlineFormattingState as a hint for the current line index does not work well
 with partial layout 

Not sure I understand the title.
Comment 3 zalan 2023-02-15 07:39:09 PST 
InlineFormattingState only contains the line generated at the current layout. With partial layout, this number may be very different from how many lines we actually have altogether.
Comment 4 EWS 2023-02-16 09:03:29 PST 
Committed 260372@main (2e812cbdaf7d): <https://commits.webkit.org/260372@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 464994 [details].
Comment 5 Radar WebKit Bug Importer 2023-02-16 09:04:19 PST 
<rdar://problem/105550749>
Comment 6 zalan 2023-02-16 09:37:11 PST 
oops, I forgot to change the title in the commit message :(