Bug 252309 - Zydis fails to build in Debug mode with -Werror=type-limits (GCC 12.2 / SCCACHE)
Summary: Zydis fails to build in Debug mode with -Werror=type-limits (GCC 12.2 / SCCACHE)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Claudio Saavedra
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-15 03:43 PST by Claudio Saavedra
Modified: 2023-03-15 10:21 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2023-02-15 03:43:30 PST 
Should those be using ZYAN_STATIC_ASSERT() instead of ZYAN_ASSERT()?

In file included from /app/webkit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-fa42537c-2-c.c:1:
/app/webkit/Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisDecoder.c: In function 'ZydisSetAttributes':
/app/webkit/Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisDecoder.c:2206:30: error: comparison is always true due to limited range of data type [-Werror=type-limits]
/app/webkit/Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisDecoder.c:2206:30: error: comparison is always true due to limited range of data type [-Werror=type-limits]
/app/webkit/Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisDecoder.c:2219:30: error: comparison is always true due to limited range of data type [-Werror=type-limits]
/app/webkit/Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisDecoder.c:2219:30: error: comparison is always true due to limited range of data type [-Werror=type-limits]
/app/webkit/Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisDecoder.c:2232:30: error: comparison is always true due to limited range of data type [-Werror=type-limits]
/app/webkit/Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisDecoder.c:2232:30: error: comparison is always true due to limited range of data type [-Werror=type-limits]
/app/webkit/Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisDecoder.c: In function 'ZydisSetEffectiveOperandWidth':
/app/webkit/Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisDecoder.c:3656:33: error: comparison is always true due to limited range of data type [-Werror=type-limits]
/app/webkit/Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisDecoder.c:3656:33: error: comparison is always true due to limited range of data type [-Werror=type-limits]
In file included from /app/webkit/WebKitBuild/Debug/JavaScriptCore/DerivedSources/unified-sources/UnifiedSource-fa42537c-2-c.c:8:
/app/webkit/Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisSharedData.c: In function 'ZydisGetOperandDefinitions':
/app/webkit/Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisSharedData.c:123:34: error: comparison is always true due to limited range of data type [-Werror=type-limits]
/app/webkit/Source/JavaScriptCore/disassembler/zydis/Zydis/ZydisSharedData.c:123:34: error: comparison is always true due to limited range of data type [-Werror=type-limits]
cc1: all warnings being treated as errors
sccache: Compiler killed by signal 1
ninja: build stopped: subcommand failed.
Comment 1 Claudio Saavedra 2023-02-15 03:47:53 PST 
Actually, unless I am missing something, those asserts are useless.
Comment 2 Radar WebKit Bug Importer 2023-02-22 03:44:15 PST 
<rdar://problem/105772644>
Comment 3 Claudio Saavedra 2023-03-14 07:00:27 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/11492
Comment 4 EWS 2023-03-15 10:21:28 PDT 
Committed 261696@main (4f087256dcd6): <https://commits.webkit.org/261696@main>

Reviewed commits have been landed. Closing PR #11492 and removing active labels.