Bug 252323 - [margin-trim] Change shouldChildInlineMarginContributeToContainerIntrinsicSize to be a virtual method on RenderBlock
Summary: [margin-trim] Change shouldChildInlineMarginContributeToContainerIntrinsicSiz...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sammy Gill
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-15 10:02 PST by Sammy Gill
Modified: 2023-02-26 08:18 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sammy Gill 2023-02-15 10:02:34 PST 
It is a little strange in the way that we currently use this method (immediately downcast to RenderBlockFlow). It would be a better interface if it was a virtual method on RenderBlock and gets overridden in RenderBlockFlow
Comment 1 Radar WebKit Bug Importer 2023-02-15 10:03:00 PST 
<rdar://problem/105502226>
Comment 2 Sammy Gill 2023-02-25 20:15:47 PST 
Pull request: https://github.com/WebKit/WebKit/pull/10690
Comment 3 EWS 2023-02-26 08:18:29 PST 
Committed 260850@main (cc5d15ac506b): <https://commits.webkit.org/260850@main>

Reviewed commits have been landed. Closing PR #10690 and removing active labels.