Bug 252344 - [Win] Windows port needs to fix FIXME in WTF::Config::permanentlyFreeze() in JSCConfig.cpp
Summary: [Win] Windows port needs to fix FIXME in WTF::Config::permanentlyFreeze() in ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-15 14:12 PST by Brent Fulgham
Modified: 2023-07-31 14:55 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2023-02-15 14:12:24 PST 
Currently, we don’t mprotect the JSC::Config for the Windows port yet.  We believe Windows has a VirtualProtect API that can be used to do this.
<rdar://55547640>

#elif OS(WINDOWS)
    // FIXME: Implement equivalent, maybe with VirtualProtect.
    // Also need to fix WebKitTestRunner.

    // Note: the Windows port also currently does not support a unified Config
    // record, which is needed for the current form of the freezing feature to
    // work. See comments in PlatformEnable.h for UNIFIED_AND_FREEZABLE_CONFIG_RECORD.
#endif