Bug 252368 - [IFC][Partial layout] LineLayout::layout should not destroy inline display content on partial layout
Summary: [IFC][Partial layout] LineLayout::layout should not destroy inline display co...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-15 18:09 PST by zalan
Modified: 2023-02-17 09:05 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.60 KB, patch)
2023-02-15 18:12 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (3.69 KB, patch)
2023-02-16 16:39 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-02-15 18:09:58 PST 
ssia
Comment 1 zalan 2023-02-15 18:12:36 PST 
Created attachment 465015 [details]
Patch
Comment 2 Antti Koivisto 2023-02-16 07:16:40 PST 
Comment on attachment 465015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465015&action=review

> Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:533
> +    // FIXME: Partial layout should not rely on inline display content, but instead InlineFormattingState
> +    // should retain all the pieces of data required -and then we can destroy damaged content here instead of after
> +    // layout in constructContent.

good plan
Comment 3 zalan 2023-02-16 16:39:53 PST 
Created attachment 465039 [details]
Patch
Comment 4 EWS 2023-02-17 09:04:40 PST 
Committed 260448@main (7949435ac60b): <https://commits.webkit.org/260448@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465039 [details].
Comment 5 Radar WebKit Bug Importer 2023-02-17 09:05:20 PST 
<rdar://problem/105599284>