Bug 252379 - REGRESSION (255598@main): checkbox overlaps Log In button on ally.com
Summary: REGRESSION (255598@main): checkbox overlaps Log In button on ally.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-15 21:47 PST by zalan
Modified: 2023-02-16 10:21 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.83 KB, patch)
2023-02-15 21:57 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (6.60 KB, patch)
2023-02-16 07:50 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2023-02-15 21:47:56 PST 
<rdar://104303475>
Comment 1 zalan 2023-02-15 21:57:08 PST 
Created attachment 465019 [details]
Patch
Comment 2 Antti Koivisto 2023-02-16 07:00:00 PST 
Comment on attachment 465019 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=465019&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:278
> +        if (displayBox.isInlineLevelBox() && !displayBox.isRootInlineBox())

there is isNonRootInlineLevelBox()
Comment 3 zalan 2023-02-16 07:22:28 PST 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 465019 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=465019&action=review
> 
> > Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:278
> > +        if (displayBox.isInlineLevelBox() && !displayBox.isRootInlineBox())
> 
> there is isNonRootInlineLevelBox()
!!!
Comment 4 zalan 2023-02-16 07:50:54 PST 
Created attachment 465026 [details]
Patch
Comment 5 EWS 2023-02-16 10:21:21 PST 
Committed 260380@main (3cf4b3198445): <https://commits.webkit.org/260380@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 465026 [details].