WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
252442
Add String / StringView find() overloads that take in a LChar / char instead of a UChar
https://bugs.webkit.org/show_bug.cgi?id=252442
Summary
Add String / StringView find() overloads that take in a LChar / char instead ...
Chris Dumez
Reported
2023-02-16 16:18:21 PST
Add String / StringView find() overloads that take in a LChar / char instead of a UChar. It is pretty common to see code in WebKit doing `string.find(':')`. When the input string is 8-bit, converting ':' to a UChar can be inefficient as we have optimized versions of StringImpl::find() / WTF::find() that take in a LChar/char.
Attachments
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2023-02-16 16:21:18 PST
Pull request:
https://github.com/WebKit/WebKit/pull/10239
EWS
Comment 2
2023-02-16 19:02:03 PST
Committed
260415@main
(2984e2efc933): <
https://commits.webkit.org/260415@main
> Reviewed commits have been landed. Closing PR #10239 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-02-16 19:03:20 PST
<
rdar://problem/105576849
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug