Bug 252449 - [GCC] Ubuntu 20.04 build error after 260367@main
Summary: [GCC] Ubuntu 20.04 build error after 260367@main
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2023-02-16 19:52 PST by Diego Pino
Modified: 2023-02-16 23:04 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2023-02-16 19:52:34 PST 
The WebKitGTK Ubuntu 20.04 build bot is failing with the following error:

```
error: could not convert ‘context.WebCore::WebGLExtensionScopedContext::operator->()->WebCore::WebGLRenderingContextBase::graphicsContextGL()->WebCore::GraphicsContextGL::getQueryObjectui64EXT((& query)->WebCore::WebGLTimerQueryEXT::<anonymous>.WebCore::WebGLContextObject::<anonymous>.WebCore::WebGLObject::object(), pname)’ from ‘GCGLuint64’ {aka ‘long unsigned int’} to ‘WebCore::WebGLAny’ {aka ‘std::variant<std::nullptr_t, bool, int, unsigned int, long long int, long long unsigned int, float, WTF::String, WTF::Vector<bool, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>, WTF::Vector<int, 0, WTF::CrashOnOverflow, 16, WTF::FastMalloc>
```

This bug is similar to https://bugs.webkit.org/show_bug.cgi?id=244568. In this case, since WebGLAny doesn't support "long unsigned" it's necessary to do an explicit static cast to "long long unsigned" (supported by WebGLAny).
Comment 1 Diego Pino 2023-02-16 20:00:58 PST 
Pull request: https://github.com/webkit/webkit/pull/10246
Comment 2 EWS 2023-02-16 23:03:23 PST 
Committed 260428@main (a436f19b905c): <https://commits.webkit.org/260428@main>

Reviewed commits have been landed. Closing PR #10246 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-02-16 23:04:21 PST 
<rdar://problem/105583905>